linux-kernel - Re: [PATCH -v2 00/16] PCI: Re-factor PCI's 'latency timer' setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Nov 2011 09:43:50 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	Myron Stowe <myron.stowe@...hat.com>, linux-pci@...r.kernel.org,
	linux@....linux.org.uk, vapier@...too.org, dhowells@...hat.com,
	ysato@...rs.sourceforge.jp, tony.luck@...el.com,
	fenghua.yu@...el.com, monstr@...str.eu, ralf@...ux-mips.org,
	paulus@...ba.org, lethal@...ux-sh.org, davem@...emloft.net,
	cmetcalf@...era.com, gxt@...c.pku.edu.cn, tglx@...utronix.de,
	mingo@...hat.com, chris@...kel.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -v2 00/16] PCI: Re-factor PCI's 'latency timer' setup

On Fri, 2011-11-11 at 09:59 -0800, Jesse Barnes wrote:
> On Fri, 28 Oct 2011 15:47:26 -0600
> Myron Stowe <myron.stowe@...hat.com> wrote:
> 
> > The 'latency timer' of PCI devices, both Type 0 and Type 1,
> > is setup in architecture-specific code [see: pcibios_set_master()].
> > There are two approaches being taken by all the architectures - check
> > if the 'latency timer' is currently set between 16 and 255 and if not
> > bring it within bounds, or, do nothing (and then there is the
> > gratuitously different parisc implementation).
> > 
> > There is nothing architecture-specific about PCI's 'latency timer' so
> > this patch pulls the setup functionality up into the PCI core by
> > creating a generic 'pcibios_set_master()' function using the '__weak'
> > attribute which can be used by all architectures as a default which,
> > if necessary, can then be over-ridden by architecture-specific code.
> 
> I have acks from Chris, Ralf, and Mike.  Any other arch maintainers
> want to ack or nack this before it goes into my -next branch?

I somewhat missed the original patch. As long as it's a nop for ppc, I
don't care tho :-)

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/