lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Nov 2011 03:21:54 +0000 From: Liu Gang-B34182 <B34182@...escale.com> To: Wood Scott-B07421 <B07421@...escale.com> CC: Li Yang-R58472 <r58472@...escale.com>, Jiang Kai-B18973 <B18973@...escale.com>, "'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>, Zang Roy-R61911 <r61911@...escale.com>, "'Alexandre.Bounine@....com'" <Alexandre.Bounine@....com>, "'akpm@...ux-foundation.org'" <akpm@...ux-foundation.org>, "'linuxppc-dev@...ts.ozlabs.org'" <linuxppc-dev@...ts.ozlabs.org>, Gala Kumar-B11780 <B11780@...escale.com> Subject: RE: [PATCH 4/5, v3] powerpc/8xxx: Update device tree bus probe for new RapidIO node binding Yeah, send binding first should be better for reviewing entire set of patches. Thanks! -----Original Message----- From: Wood Scott-B07421 Sent: Tuesday, November 15, 2011 1:37 AM To: Liu Gang-B34182 Cc: Li Yang-R58472; Jiang Kai-B18973; linux-kernel@...r.kernel.org; Zang Roy-R61911; Alexandre.Bounine@....com; akpm@...ux-foundation.org; linuxppc-dev@...ts.ozlabs.org; Gala Kumar-B11780 Subject: Re: [PATCH 4/5, v3] powerpc/8xxx: Update device tree bus probe for new RapidIO node binding On 11/14/2011 11:35 AM, Scott Wood wrote: > On 11/12/2011 06:02 AM, Liu Gang wrote: >> From: Kai Jiang <Kai.Jiang@...escale.com> >> >> Update of_platform_bus_probe() RapidIO node to be compitable with new >> RapidIO dts compatible property. >> >> Signed-off-by: Kai Jiang <Kai.Jiang@...escale.com> >> Signed-off-by: Kumar Gala <galak@...nel.crashing.org> >> --- >> arch/powerpc/platforms/85xx/corenet_ds.c | 2 +- >> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 2 +- >> arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/powerpc/platforms/85xx/corenet_ds.c >> b/arch/powerpc/platforms/85xx/corenet_ds.c >> index 802ad11..c48b661 100644 >> --- a/arch/powerpc/platforms/85xx/corenet_ds.c >> +++ b/arch/powerpc/platforms/85xx/corenet_ds.c >> @@ -112,7 +112,7 @@ static const struct of_device_id of_device_ids[] __devinitconst = { >> .compatible = "simple-bus" >> }, >> { >> - .compatible = "fsl,rapidio-delta", >> + .compatible = "fsl,srio", > > fsl,srio is too vague. We need to identify the specific hardware (or > at least a concrete programming interface document), not just the bus > that the hardware implements. Never mind, I see that the binding is more specific about what this string means. Next time have the binding come first. :-) -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists