linux-kernel - [PATCH 00/16] Timekeeping cleanups and locking changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Nov 2011 20:03:50 -0800
From:	John Stultz <john.stultz@...aro.org>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	John Stultz <john.stultz@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Richard Cochran <richardcochran@...il.com>
Subject: [PATCH 00/16] Timekeeping cleanups and locking changes

Hey Thomas,

THIS IS PATCHWAR!

After your 7 patch patchbomb reworking much of the timekeeping locking
from this morning, I decided such aggression will not stand.

So here's 16 patches, some are your patches, just lobbed back, targeting
strategic locations of your inbox.

Its all pretty rough, and the whole set likely needs some refactoring, but
I wanted to let you see my take on your approach. Much of this are changes
I've intended to get to, but have just been too busy of late.

I also included a similar shadow-update trick to reduce the lock 
hold times, but as noted in the patch, I'm still worried about the
likely race there, and we need to do some further vetting to ensure
it really can't cause trouble (as well as warnings to anyone trying 
to later understand the rational there).

I also still need to refactor the update_vsyscall implementations to
utilize the xsec_nsec, so we can avoid truncation issues without 
mucking with the ntp_error code.

Anyway, let me know what you think.

-john

CC: Thomas Gleixner <tglx@...utronix.de>
CC: Eric Dumazet <eric.dumazet@...il.com>
CC: Richard Cochran <richardcochran@...il.com>

Patches are also available here:
(Fair warning, I may rebase the following branch)

 git://git.linaro.org/people/jstultz/linux.git dev/xtime-breakup

John Stultz (14):
  time: Move total_sleep_time into the timekeeper structure
  time: Move wall_to_monotonic into the timekeeper structure
  time: Move xtime into timekeeeper structure
  time: Move raw_time into timekeeper structure
  time: Cleanup global variables and move them to the top
  time: Add timekeeper lock
  ntp: Cleanup timex.h
  ntp: Access tick_length variable via ntp_tick_length()
  ntp: Add ntp_lock to replace xtime_locking
  time: Remove most of xtime_lock usage in timekeeping.c
  time: Condense timekeeper.xtime into xtime_sec
  time: Rework timekeeping functions to take timekeeper ptr as argument
  time: Update tiemkeeper structure using a local shadow
  time: Rework update_vsyscall to pass timekeeper

Thomas Gleixner (2):
  time: Reorder so the hot data is together
  time: Move common updates to a function

 arch/ia64/kernel/time.c       |   28 ++--
 arch/powerpc/kernel/time.c    |   25 +-
 arch/s390/kernel/time.c       |   18 +-
 arch/x86/kernel/vsyscall_64.c |   21 +-
 include/linux/clocksource.h   |    9 -
 include/linux/timekeeper.h    |   75 +++++++
 include/linux/timex.h         |   17 +--
 kernel/time/ntp.c             |   83 ++++++--
 kernel/time/timekeeping.c     |  494 +++++++++++++++++++++--------------------
 9 files changed, 442 insertions(+), 328 deletions(-)
 create mode 100644 include/linux/timekeeper.h

-- 
1.7.3.2.146.gca209

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/