linux-kernel - Re: [PATCH] dmaengine/ste_dma40: support pm in dma40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Nov 2011 12:36:46 +0530
From:	Narayanan G <narayanan.gopalakrishnan@...ricsson.com>
To:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Vinod Koul <vinod.koul@...el.com>
Cc:	Linus WALLEIJ <linus.walleij@...ricsson.com>,
	Rabin VINCENT <rabin.vincent@...ricsson.com>
Subject: Re: [PATCH] dmaengine/ste_dma40: support pm in dma40

On Wed, Nov 16, 2011 at 07:30:03 +0100, Narayanan GOPALAKRISHNAN wrote:
> This patch adds power management support to the dma40
> driver. The DMA registers are backed up and restored,
> during suspend/resume. Also flags to track the dma usage
> have been introduced to facilitate this. Patch also includes
> few other minor changes, related to formatting, grammar.
> 
> Signed-off-by: Narayanan G <narayanan.gopalakrishnan@...ricsson.com>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> ---
> +       spinlock_t                        usage_lock;
> +       u32                               reg_val_backup[BACKUP_REGS_SZ];
> +       u32                               reg_val_backup_v3[BACKUP_REGS_SZ_V3];
> +       u32                              *reg_val_backup_chan;
> +       bool                              initialized;

Made this more readable.

> 
> +static void d40_power_off(struct d40_base *base, int phy_num)
> +{
> +       u32 gcc;
> +       int i;
> +       int j;
> +       int p;
> +
> +       /*
> +        * Disable the rest of the code for v1, because of GCC register HW bugs
> +        * which are not worth working around.
> +        */
> +       if (base->rev == 1)
> +               return;
> +

removed the unconditional return.

> +static void d40_power_on(struct d40_base *base, int phy_num)
> +{
> +       u32 gcc;
> +
> +       /*
> +        * Disable the rest of the code for v1, because of GCC register HW bugs
> +        * which are not worth working around.
> +        */
> +       if (base->rev == 1)
> +               return;

Again, removed the unconditional return.

Other changes from v1 of this patch:
1. Removed the usage counter and manage with the pm_runtime_xxx funcs.
2. Do not switch off the reserved channels.

Thanks,
Narayanan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/