linux-kernel - Re: [PATCH] usb : gadget : usbstring : fix style problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111116110912.GD27980@legolas.emea.dhcp.ti.com>
Date:	Wed, 16 Nov 2011 13:09:13 +0200
From:	Felipe Balbi <balbi@...com>
To:	Tonylijo <mail@...ylijo.in>
Cc:	Felipe Balbi <balbi@...com>, Greg Kroah-Hartman <gregkh@...e.de>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb : gadget : usbstring : fix style problems

On Wed, Nov 16, 2011 at 10:13:02AM +0530, Tonylijo wrote:
> Minor fixes for problems found by checkpatch.pl in usbstring.c.

list here the return from checkpatch.pl --terse just so we know what
you're fixing.

> Signed-off-by: Tonylijo Jose <mail@...ylijo.in>
> ---
> diff --git a/drivers/usb/gadget/usbstring.c
> b/drivers/usb/gadget/usbstring.c
> index 58c4d37..2bdc56a 100644
> --- a/drivers/usb/gadget/usbstring.c
> +++ b/drivers/usb/gadget/usbstring.c
> @@ -32,8 +32,9 @@ static int utf8_to_utf16le(const char *s, __le16 *cp,
> unsigned len)
>  	 */
>  	while (len != 0 && (c = (u8) *s++) != 0) {
>  		if (unlikely(c & 0x80)) {
> -			// 2-byte sequence:
> -			// 00000yyyyyxxxxxx = 110yyyyy 10xxxxxx
> +			/* 2-byte sequence:
> +			 * 00000yyyyyxxxxxx = 110yyyyy 10xxxxxx
> +			 */

still wrong. This should've been:

/*
 * 2-byte sequence
 * 00000yyyyyxxxxxx = 110yyyyy 10xxxxxx
 */

likewise all bellow.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)