linux-kernel - RE: [PATCH 1/1] gpio: introduce gpio_export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65EE16ACC360FA4D99C96DC085B3F7722D5CE0@039-SN1MPN1-002.039d.mgd.msft.net>
Date:	Wed, 16 Nov 2011 13:43:27 +0000
From:	Dong Aisheng-B29396 <B29396@...escale.com>
To:	Stephen Warren <swarren@...dia.com>,
	Dong Aisheng <dong.aisheng@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"arnd@...db.de" <arnd@...db.de>
Subject: RE: [PATCH 1/1] gpio: introduce gpio_export_array to ease export
 for gpio arrays

> -----Original Message-----
> From: linux-kernel-owner@...r.kernel.org [mailto:linux-kernel-
> owner@...r.kernel.org] On Behalf Of Stephen Warren
> Sent: Wednesday, November 16, 2011 2:37 AM
> To: Dong Aisheng; linux-kernel@...r.kernel.org
> Cc: grant.likely@...retlab.ca; arnd@...db.de
> Subject: RE: [PATCH 1/1] gpio: introduce gpio_export_array to ease export
> for gpio arrays
> 
> Dong Aisheng wrote at Tuesday, November 15, 2011 2:54 AM:
> > Introduce gpio_export_array function to ease the export operation for
> > gpio arrays.
> > This can cooperate with the exist gpio_request_array function.
> ...
> > +/**
> > + * gpio_export_array - export multiple GPIOs in a single call
> > + * @array:	array of the 'struct gpio'
> > + * @num:	how many GPIOs in the array
> > + */
> > +int gpio_export_array(const struct gpio *array, size_t num,
> > +			bool direction_may_change)
> 
> Should direction_may_change be added to "struct gpio" so it can vary per
> pin?
> 
I just thougt that after adding this member(or flag) into struct gpio,
we may not need gpio_export_array function. It can be done in gpio_request_one
by checking the flag just like wolfram's patch does (I just found his patch).
It seems his patch is more light to implement this function.

> I might this new function to create its own parameter type instead of re-
> using struct gpio, but I guess the main value here is re-using the data
> passed to both request_array and export_array.
> 
Agree. :-)

Regards
Dong Aisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/