| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CABqxG0dNoXjpOtug62TLX+as0CAt_niQc=msZTh+heLv8zLQyg@mail.gmail.com> Date: Wed, 16 Nov 2011 09:15:12 +0800 From: Dave Young <hidave.darkstar@...il.com> To: Tejun Heo <tj@...nel.org> Cc: Dave Young <dyoung@...hat.com>, gregkh@...e.de, cl@...ux-foundation.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org Subject: Re: [PATCCH percpu: add cpunum param in per_cpu_ptr_to_phys On Tue, Nov 15, 2011 at 10:49 PM, Tejun Heo <tj@...nel.org> wrote: > On Tue, Nov 15, 2011 at 04:36:46PM +0800, Dave Young wrote: >> per_cpu_ptr_to_phys iterate all cpu to get the phy addr >> let's leave the caller to pass the cpu number to it. >> >> Actually in the only one user show_crash_notes, >> cpunum is provided already before calling this. >> >> Signed-off-by: Dave Young <dyoung@...hat.com> > > Does this matter? If it's not a performance critical path, I'd rather > keep the generic funtionality. Hi, why not? the code is redundant, it's an improvement of the code, isn't it? Also, kernel code size will be smaller. > > Thanks. > > -- > tejun > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@...ck.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a> > -- Regards Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists