linux-kernel - Re: [PATCH] include/log2.h: Fix rounddown_pow_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1472546.S58to4y67R@donald.sf-tec.de>
Date:	Wed, 16 Nov 2011 23:51:01 +0100
From:	Rolf Eike Beer <eike-kernel@...tec.de>
To:	Andrei Warkentin <andreiw@...are.com>
Cc:	linux-kernel@...r.kernel.org, opensuse-kernel@...nsuse.org
Subject: Re: [PATCH] include/log2.h: Fix rounddown_pow_of_two(1)

Andrei Warkentin wrote:
> 1 is a power of two, therefore rounddown_pow_of_two(1) should return 1. It
> does in case the argument is a variable but in case it's a constant it
> behaves wrong and returns 0. Probably nobody ever did it so this was never
> noticed, however net/drivers/vmxnet3 with latest GCC does and breaks on
> unicpu systems.

Obviously correct.

Reviewed-by: Rolf Eike Beer <eike-kernel@...tec.de>

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)