linux-kernel - Re: [PATCH] mm: cleanup the comment for head/tail pages of compound pages in mm/page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111117082148.GA30544@tiehlicka.suse.cz>
Date:	Thu, 17 Nov 2011 09:22:42 +0100
From:	Michal Hocko <mhocko@...e.cz>
To:	Wang Sheng-Hui <shhuiw@...il.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	trivial@...nel.org
Subject: Re: [PATCH] mm: cleanup the comment for head/tail pages of compound
 pages in mm/page_alloc.c

[CCing trivial tree]

Unquoted patch at https://lkml.org/lkml/2011/11/15/402

On Wed 16-11-11 08:05:07, Wang Sheng-Hui wrote:
[...]
> Thanks, Michal.
> 
> New patch generated.
> 
> 
> [PATCH] mm: cleanup the comment for head/tail pages of compound pages in mm/page_alloc.c
> 
> Only tail pages point at the head page using their ->first_page fields.
> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@...il.com>

Reviewed-by: Michal Hocko <mhocko@...e.cz>

> ---
>  mm/page_alloc.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 6e8ecb6..e7dd848 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -332,8 +332,8 @@ out:
>   *
>   * The remaining PAGE_SIZE pages are called "tail pages".
>   *
> - * All pages have PG_compound set.  All pages have their ->private pointing at
> - * the head page (even the head page has this).
> + * All pages have PG_compound set.  All tail pages have their ->first_page
> + * pointing at the head page.
>   *
>   * The first tail page's ->lru.next holds the address of the compound page's
>   * put_page() function.  Its ->lru.prev holds the order of allocation.
> -- 
> 1.7.1

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/