linux-kernel - Re: [PATCH] dmaengine/ste_dma40: support pm in dma40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1321518712.1516.181.camel@vkoul-udesk3>
Date:	Thu, 17 Nov 2011 14:01:51 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Narayanan G <narayanan.gopalakrishnan@...ricsson.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linus WALLEIJ <linus.walleij@...ricsson.com>,
	Rabin VINCENT <rabin.vincent@...ricsson.com>
Subject: Re: [PATCH] dmaengine/ste_dma40: support pm in dma40

On Thu, 2011-11-17 at 12:10 +0530, Narayanan G wrote:
> On Thu, Nov 17, 2011 at 06:23:52 +0100, Vinod Koul wrote:
> > runtime pm manages the device power management. It will call your
> > suspend/resume callbacks when your device is idle/active and manages the
> > device usage for you.
> > Within your device you need to do your own management, which should be
> > linked to channel being active. You should not club the two.
> > 
> > I am not sure if the clock framework can help you on this
> 
> Instead of switching on and off eventlines very frequently, I'll
> do it in the runtime_suspend() and runtime_resume(), so that it
> looks more neat and can get away with these usage counters.
> I will re-work and submit a new version of this patch.
if you want to do your clock switching per channel based then you cant
do in runtime_resume/suspned code which seems to be approach. As I said
its device specific, so if you move all to these callbacks then you can
easily eliminate the mess in patch right now and make it cleaner.


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/