linux-kernel - Re: [PATCH 2/2] lockdep: print lock name for lockdep_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111117084435.GA16757@zhy>
Date:	Thu, 17 Nov 2011 16:44:35 +0800
From:	Yong Zhang <yong.zhang0@...il.com>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	mingo@...e.hu, a.p.zijlstra@...llo.nl, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] lockdep: print lock name for lockdep_init_error

On Thu, Nov 17, 2011 at 04:01:16PM +0800, Ming Lei wrote:
> Hi,
> 
> Thanks for your review.
> 
> On Thu, Nov 17, 2011 at 2:02 PM, Yong Zhang <yong.zhang0@...il.com> wrote:
> > On Thu, Nov 17, 2011 at 01:34:32PM +0800, tom.leiming@...il.com wrote:
> >> From: Ming Lei <tom.leiming@...il.com>
> >>
> >> This patch prints the name of the lock which is acquired
> >> before lockdep_init is called, so that user can easily find
> >> which lock trigged the lockdep init error warning.
> >
> > Should we care about that?
> 
> Yes, we should, see below.
> 
> >
> > I think lockdep_init() called early enough give more hint.
> > Such as be the first C function called by arch.
> 
> Maybe not early enough, before start_kernel is executed, arch
> asm code still can call some C function, can't it?

To me that still means 'Arch code didn't call lockdep_init()
early enough'.

But anyway, let Peter/Ingo decide it.

Thanks,
Yong
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/