linux-kernel - Re: [PATCH 2/8] serial: 8250: Add ioctl to enable auto rs485 mode with some Exar UARTs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111117100957.GC2535@pengutronix.de>
Date:	Thu, 17 Nov 2011 11:09:57 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Claudio Scordino <claudio@...dence.eu.com>
Cc:	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alan Cox <alan@...ux.intel.com>,
	Juergen Beisert <jbe@...gutronix.de>,
	Matthias Fuchs <mfuchs@...fu.de>
Subject: Re: [PATCH 2/8] serial: 8250: Add ioctl to enable auto rs485 mode
 with some Exar UARTs


> > +		if (serial_inp(up, UART_FCTR)&  UART_FCTR_RS485)
> > +			rs485ctrl.flags = SER_RS485_ENABLED;
> > +		else
> > +			rs485ctrl.flags = 0;
> 
> This else branch may be removed, since the structure has been already memsetted to 0.

Correct, yet I didn't want to change Matthias' code, so reviewers can
skip this patch if they reviewed his old code already. Flag handling
will be handled different with the next patch anyway.

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)