linux-kernel - Re: [PATCH] usb : gadget : usbstring : fix style problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1321526757.2367.20.camel@debian1.ic>
Date:	Thu, 17 Nov 2011 16:15:57 +0530
From:	Tonylijo <mail@...ylijo.in>
To:	balbi@...com
Cc:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb : gadget : usbstring : fix style problems

On Wed, 2011-11-16 at 13:09 +0200, Felipe Balbi wrote:
> On Wed, Nov 16, 2011 at 10:13:02AM +0530, Tonylijo wrote:
> > Minor fixes for problems found by checkpatch.pl in usbstring.c.
> 
> list here the return from checkpatch.pl --terse just so we know what
> you're fixing.
> 
> > Signed-off-by: Tonylijo Jose <mail@...ylijo.in>
> > ---
> > diff --git a/drivers/usb/gadget/usbstring.c
> > b/drivers/usb/gadget/usbstring.c
> > index 58c4d37..2bdc56a 100644
> > --- a/drivers/usb/gadget/usbstring.c
> > +++ b/drivers/usb/gadget/usbstring.c
> > @@ -32,8 +32,9 @@ static int utf8_to_utf16le(const char *s, __le16 *cp,
> > unsigned len)
> >  	 */
> >  	while (len != 0 && (c = (u8) *s++) != 0) {
> >  		if (unlikely(c & 0x80)) {
> > -			// 2-byte sequence:
> > -			// 00000yyyyyxxxxxx = 110yyyyy 10xxxxxx
> > +			/* 2-byte sequence:
> > +			 * 00000yyyyyxxxxxx = 110yyyyy 10xxxxxx
> > +			 */
> 
> still wrong. This should've been:
> 
> /*
>  * 2-byte sequence
>  * 00000yyyyyxxxxxx = 110yyyyy 10xxxxxx
>  */
> 
> likewise all bellow.
> 
Thanks for your review. I will send the corrected patch soon.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/