linux-kernel - Re: [PATCH 1/2] Initial PCI support for Atheros 724x SoCs. (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111117143331.GE20183@linux-mips.org>
Date:	Thu, 17 Nov 2011 14:33:32 +0000
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Rene Bolldorf <xsecute@...glemail.com>
Cc:	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Initial PCI support for Atheros 724x SoCs. (v2)

On Thu, Nov 17, 2011 at 03:02:56PM +0100, Rene Bolldorf wrote:

Queued for 3.3 but:

> Subject: [PATCH 1/2] Initial PCI support for Atheros 724x SoCs. (v2)

Please don't put the (v2) at the end of the subject line but rather into
the initial part with the square brackets like:

Subject: [PATCH 1/2, v2] Initial PCI support for Atheros 724x SoCs.

That's so software like git-am will automatically discard that when
applying a patch.

Your use of non-ASCII characters is not quite yet supported in patchwork,
see:

  http://patchwork.linux-mips.org/patch/3019/
  http://patchwork.linux-mips.org/patch/3020/

My surname's spelling  is also suffering from ASCII brain damaged software ...

> +	switch (size) {
> +	case 1:
> +		addr = where & ~3;
> +		mask = 0xff000000 >> ((where % 4) * 8);
> +		tval = reg_read(ATH724X_PCI_DEV_BASE + addr);
> +		tval = tval & ~mask;
> +		*value = (tval >> ((4 - (where % 4))*8));
> +	break;
> +	case 2:

That's a very odd style of formatting.  The Linux coding style (see
Documentation/) wants the break keyword indented with the same number
of tabs as the preceeding block.

Anyway, I took care of that.

Thanks,

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/