linux-kernel - Re: [RFC PATCH 3/5] x86: add a sysctl parameter to panic on stack overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EC53105.4050301@zytor.com>
Date:	Thu, 17 Nov 2011 08:06:29 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	HAYASAKA Mitsuo <mitsuo.hayasaka.hu@...achi.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Randy Dunlap <rdunlap@...otime.net>, x86@...nel.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	yrl.pp-manager.tt@...achi.com
Subject: Re: [RFC PATCH 3/5] x86: add a sysctl parameter to panic on stack
 overflow

On 11/17/2011 08:00 AM, Konrad Rzeszutek Wilk wrote:
>>
>> I don't mind if I add __read_mostly here, but I think it's not
>> necessary because this variable is seldom read as well.
> 
> The definition of __read_mostly is that it moves this variable to a cold cache area.
> Which is what you want.
> 

Not really.  __read_mostly moves a variable to an area that is expected
to spent most its time in the cache-shared state and rarely be
invalidated.  It does NOT mean that it is cold.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/