linux-kernel - Re: [PATCH] x86/platform: (TS-5500) fix CONFIG_TS5500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111117135731.1c8e736e@v0nbox>
Date:	Thu, 17 Nov 2011 13:57:31 -0500
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	x86@...nel.org, Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/platform: (TS-5500) fix CONFIG_TS5500_ADC
 dependency

On Thu, 17 Nov 2011 10:39:06 -0800,
"H. Peter Anvin" <hpa@...or.com> wrote:

> On 11/17/2011 10:36 AM, Vivien Didelot wrote:
> > Hi Ingo,
> > 
> > Here's the fix for the Kconfig dependency issue, for the TS-5500
> > platform. It is based on the latest x86/platform branch from the
> > -tip tree.
> > 
> > Best,
> > 
> >     Vivien
> > 
> > Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
> > ---
> >  arch/x86/platform/ts5500/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/x86/platform/ts5500/Kconfig
> > b/arch/x86/platform/ts5500/Kconfig index be51b86..84e59a9 100644
> > --- a/arch/x86/platform/ts5500/Kconfig
> > +++ b/arch/x86/platform/ts5500/Kconfig
> > @@ -23,6 +23,6 @@ config TS5500_LED
> >  
> >  config TS5500_ADC
> >  	bool "TS-5500 ADC"
> > -	depends on TS5500
> > +	depends on TS5500 && HWMON=y
> >  	help
> >        Support for the A/D converter on Technologic Systems TS-5500
> > SBCs.
> 
> Shouldn't this be a module, too?
> 
> 	-hpa
> 

IMHO it would be overkill for such a small embedded platform to provide
device drivers as modules.

Regards,

	Vivien
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/