linux-kernel - Re: [PATCH] pstore: gracefully handle NULL pstore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jK7kJotJVU8qAjEPACW6HEbbFTfLeAG+g+ccejGsqQ-9g@mail.gmail.com>
Date:	Thu, 17 Nov 2011 11:37:53 -0800
From:	Kees Cook <keescook@...omium.org>
To:	Tony Luck <tony.luck@...il.com>
Cc:	linux-kernel@...r.kernel.org, Matthew Garrett <mjg@...hat.com>,
	Chen Gong <gong.chen@...ux.intel.com>,
	Don Zickus <dzickus@...hat.com>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] pstore: gracefully handle NULL pstore_info functions

On Thu, Nov 17, 2011 at 11:13 AM, Tony Luck <tony.luck@...il.com> wrote:
> On Thu, Nov 17, 2011 at 10:42 AM, Kees Cook <keescook@...omium.org> wrote:
>> -       kmsg_dump_register(&pstore_dumper);
>> +       if (psi->write && psi->buf && psi->bufsize)
>> +               kmsg_dump_register(&pstore_dumper);
>
> I can see that you might not need the other parts of the pstore
> interface if your back-end is very simple (e.g. only has space for a
> single record). But stub functions are cheap - so it isn't clear who
> should pay the overhead.

Okay, fine by me. :) I'll resend with just the open/read/close/erase checked.

-Kees

-- 
Kees Cook
ChromeOS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/