| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1321567690.2272.24.camel@koala> Date: Fri, 18 Nov 2011 00:08:08 +0200 From: Artem Bityutskiy <dedekind1@...il.com> To: b35362@...escale.com Cc: dwmw2@...radead.org, linux-mtd@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org, akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, leoli@...escale.com, scottwood@...escale.com Subject: Re: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c On Tue, 2011-11-15 at 17:29 +0800, b35362@...escale.com wrote: > From: Liu Shuo <b35362@...escale.com> > > fix whitespaces,tabs coding style issue and use #include <linux/io.h> instead of <asm/io.h> > in drivers/mtd/nand/fsl_elbc.c. > > Signed-off-by: Liu Shuo <b35362@...escale.com> > Signed-off-by: Li Yang <leoli@...escale.com> Hi, It is really matter of taste whether to use only tabs for indentations or tabs + few spaces to align nicely with the previous line. I personally prefer the latter and dislike when people use only tabs. But other people love tabs and use them everywhere, even like #define\tBLAH_BLAH\tvalue, which I find ugly, but I do not mind people using this. So no, please, let's leave the indentation as is in this file. It is ok to assume tab is 8 spaces in the kernel. Artem. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists