linux-kernel - Re: [PATCH 1/5] mfd/stmpe: Pass partnum as param to stmpe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EC48122.8050800@st.com>
Date:	Thu, 17 Nov 2011 09:06:02 +0530
From:	Viresh Kumar <viresh.kumar@...com>
To:	Rabin Vincent <rabin@....in>
Cc:	Linus WALLEIJ <linus.walleij@...ricsson.com>,
	Srinidhi KASAGAR <srinidhi.kasagar@...ricsson.com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Armando VISCONTI <armando.visconti@...com>,
	Shiraz HASHIM <shiraz.hashim@...com>,
	Vipin KUMAR <vipin.kumar@...com>,
	Rajeev KUMAR <rajeev-dlh.kumar@...com>,
	Deepak SIKRI <deepak.sikri@...com>,
	Vipul Kumar SAMAR <vipulkumar.samar@...com>,
	Amit VIRDI <Amit.VIRDI@...com>,
	Pratyush ANAND <pratyush.anand@...com>,
	Bhupesh SHARMA <bhupesh.sharma@...com>,
	"viresh.linux@...il.com" <viresh.linux@...il.com>,
	Bhavna YADAV <bhavna.yadav@...com>,
	Vincenzo FRASCINO <Vincenzo.FRASCINO@...com>,
	Mirko GARDI <mirko.gardi@...com>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>
Subject: Re: [PATCH 1/5] mfd/stmpe: Pass partnum as param to stmpe_probe()

On 11/16/2011 9:05 PM, Rabin Vincent wrote:
> On Wed, Nov 16, 2011 at 16:56, Viresh Kumar <viresh.kumar@...com> wrote:
>> partnum is required during probe to get variant's info. Currently partnum was
>> getting set in i2c interface after it is used and is not at all getting set in
>> spi interface.
> 
> So your previous patch is broken?  Please fix it and resend it instead
> since it's not merged yet.
> 

Sure.

>>
>> This can be passed as param to stmpe_probe, so that it is available early. With
>> this, there is no need of i2c interface's init() routine, as it does nothing
>> else than calling dev_set_drvdata(). So better remove this routine for i2c.
>>
>> partnum defined in struct stmpe is of no use now, as it is only used once during
>> probe of stmpe, so we can remove it from struct stmpe too.
> 
> Not quite; it's used from drivers/input/keyboard/stmpe-keypad.c.  Please
> preserve this stmpe->partnum, drop your 2/5 patch which exposes variant
> externally, and instead use stmpe->partnum in 5/5.

Yes, will do this.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/