linux-kernel - RE: [PATCH] i2c/busses: (mpc) Add support for SMBUS_READ_BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3C06C26914DACA4BB3A368F78CA0B3A712BAB1@039-SN1MPN1-004.039d.mgd.msft.net>
Date:	Fri, 18 Nov 2011 03:15:39 +0000
From:	Tang Yuantian-B29983 <B29983@...escale.com>
To:	"guenter.roeck@...csson.com" <guenter.roeck@...csson.com>
CC:	Jean Delvare <khali@...ux-fr.org>,
	Tabi Timur-B04825 <B04825@...escale.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	sun york-R58495 <R58495@...escale.com>
Subject: RE: [PATCH] i2c/busses: (mpc) Add support for SMBUS_READ_BLOCK_DATA

I have tested this patch. It works on p1022ds platform.
Thanks.

Regards,
Yuantian

> -----Original Message-----
> From: Guenter Roeck [mailto:guenter.roeck@...csson.com]
> Sent: 2011年11月18日 2:19
> To: sun york-R58495
> Cc: Jean Delvare; Tabi Timur-B04825; linux-i2c@...r.kernel.org; linux-
> kernel@...r.kernel.org; Tang Yuantian-B29983
> Subject: Re: [PATCH] i2c/busses: (mpc) Add support for
> SMBUS_READ_BLOCK_DATA
> 
> If you look closely, you may realize that the mpc_read also doesn't
> validate of any of the other parameters. Are you going to request that
> such validations be added as well ? How about the other functions in this
> driver ? Should each function also validate each of its parameters ? If
> not, where do you draw the line ?
> 
> Besides, the caller is the SMBus block read function, which does know
> that SMBus block reads are limited to 32 bytes (plus length).
> 
> Guenter
> 
>