linux-kernel - Re: [PATCH] ethtool: Use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1321631242.2885.118.camel@deadeye>
Date:	Fri, 18 Nov 2011 15:47:22 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Thomas Meyer <thomas@...3r.de>
CC:	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ethtool: Use kmemdup rather than duplicating its
 implementation

On Fri, 2011-11-18 at 00:05 +0100, Thomas Meyer wrote:
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/memdup.cocci.
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>
> ---

The one-line description should refer to 'gianfar', not 'ethtool'.
(I expect David will fix this up.)

Ben.

> diff -u -p a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c
> --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c 2011-11-07 19:37:57.036756543 +0100
> +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c 2011-11-08 10:42:14.842512269 +0100
> @@ -1410,10 +1410,9 @@ static int gfar_optimize_filer_masks(str
>  
>  	/* We need a copy of the filer table because
>  	 * we want to change its order */
> -	temp_table = kmalloc(sizeof(*temp_table), GFP_KERNEL);
> +	temp_table = kmemdup(tab, sizeof(*temp_table), GFP_KERNEL);
>  	if (temp_table == NULL)
>  		return -ENOMEM;
> -	memcpy(temp_table, tab, sizeof(*temp_table));
>  
>  	mask_table = kcalloc(MAX_FILER_CACHE_IDX / 2 + 1,
>  			sizeof(struct gfar_mask_entry), GFP_KERNEL);
> 


-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/