linux-kernel - Re: [PATCH] GPIO/pl061: Add suspend resume capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EC5D8F0.3040905@st.com>
Date:	Fri, 18 Nov 2011 09:32:56 +0530
From:	Viresh Kumar <viresh.kumar@...com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	"baruch@...s.co.il" <baruch@...s.co.il>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Armando VISCONTI <armando.visconti@...com>,
	Shiraz HASHIM <shiraz.hashim@...com>,
	Vipin KUMAR <vipin.kumar@...com>,
	Rajeev KUMAR <rajeev-dlh.kumar@...com>,
	Deepak SIKRI <deepak.sikri@...com>,
	Vipul Kumar SAMAR <vipulkumar.samar@...com>,
	Amit VIRDI <Amit.VIRDI@...com>,
	Pratyush ANAND <pratyush.anand@...com>,
	Bhupesh SHARMA <bhupesh.sharma@...com>,
	"viresh.linux@...il.com" <viresh.linux@...il.com>,
	Bhavna YADAV <bhavna.yadav@...com>,
	Vincenzo FRASCINO <Vincenzo.FRASCINO@...com>,
	Mirko GARDI <mirko.gardi@...com>
Subject: Re: [PATCH] GPIO/pl061: Add suspend resume capability

On 11/18/2011 2:04 AM, Rafael J. Wysocki wrote:
>> > +static const struct dev_pm_ops pl061_dev_pm_ops = {
>> > +	.suspend = pl061_suspend,
>> > +	.resume = pl061_resume,
> Please also include hibernation callbacks here, otherwise your code will
> break systems with hibernation enabled.
> 
> There are convenience macros for that in linux/pm.h, please use one of them.

Sure. Thanx.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/