linux-kernel - Re: [PATCH] of/platform: Allow missing address for dev name lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EC6838F.8020705@calxeda.com>
Date:	Fri, 18 Nov 2011 10:10:55 -0600
From:	Rob Herring <rob.herring@...xeda.com>
To:	Wojciech Baranowski <baranowski@...omium.org>
CC:	devicetree-discuss@...ts.ozlabs.org,
	Grant Likely <grant.likely@...retlab.ca>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of/platform: Allow missing address for dev name lookup

On 11/18/2011 09:09 AM, Wojciech Baranowski wrote:
> While looking up linux name for platform device, check the address only if it
> has been supplied in lookup table.
> 
And the reason you want to do this is?

Rob

> Signed-off-by: Wojciech Baranowski <baranowski@...omium.org>
> ---
>  drivers/of/platform.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index cbd5d70..94763c0 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -314,12 +314,14 @@ static const struct of_dev_auxdata *of_dev_lookup(const struct of_dev_auxdata *l
>  	if (!lookup)
>  		return NULL;
>  
> -	for(; lookup->name != NULL; lookup++) {
> +	for (; lookup->name != NULL; lookup++) {
>  		if (!of_device_is_compatible(np, lookup->compatible))
>  			continue;
> -		if (of_address_to_resource(np, 0, &res))
> +		if (lookup->phys_addr &&
> +				of_address_to_resource(np, 0, &res))
>  			continue;
> -		if (res.start != lookup->phys_addr)
> +		if (lookup->phys_addr &&
> +				res.start != lookup->phys_addr)
>  			continue;
>  		pr_debug("%s: devname=%s\n", np->full_name, lookup->name);
>  		return lookup;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/