linux-kernel - Re: [PATCH] unlzo: Fix input buffer free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111118191009.2b695416@tukaani.org>
Date:	Fri, 18 Nov 2011 19:10:09 +0200
From:	Lasse Collin <lasse.collin@...aani.org>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] unlzo: Fix input buffer free

On 2011-11-17 Sascha Hauer wrote:
> unlzo modifies the pointer to in_buf, so we have to free the
> original buffer, not the modified pointer.

The fix looks good.

> This only happens when a fill function is passed, a case which is
> currently unused in the kernel.

It is used for initrd decompression (not initramfs) in
init/do_mounts_rd.c in crd_load(). The problematic code can only get
run when the initrd is corrupt and thus the system will panic anyway.

-- 
Lasse Collin  |  IRC: Larhzu @ IRCnet & Freenode
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/