linux-kernel - Re: [Keyrings] [PATCH] KEYS: Allow special keyrings to be cleared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1321641219.2653.13.camel@lade.trondhjem.org>
Date:	Fri, 18 Nov 2011 20:33:39 +0200
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	Steve Dickson <SteveD@...hat.com>
Cc:	David Howells <dhowells@...hat.com>, jmorris@...hat.com,
	keyrings@...ux-nfs.org, linux-nfs@...r.kernel.org,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Keyrings] [PATCH] KEYS: Allow special keyrings to be cleared

On Fri, 2011-11-18 at 09:36 -0500, Steve Dickson wrote: 
> Hey Trond,
> 
> Could you please add this patch to David's patch set?

David's patchset is not going upstream through my tree; I believe it is
supposed to be merged via the security tree.

That said, you might want to fix up the changelog entry. Something seems
to be amiss in the second sentence.

Cheers
  Trond

> Author: Steve Dickson <steved@...hat.com>
> Date:   Fri Nov 18 09:29:17 2011 -0500
> 
>     KEYS: allow keys to be revoked from the keyring
>     
>     To aid in cleaning up invalid id mappings add
>     the write bit to the key permission. Allowing
>     only root will be able to revoke the keys.
>     
>     Signed-off-by: Steve Dickson <steved@...hat.com>
> 
> diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
> index 47d1c6f..652238c 100644
> --- a/fs/nfs/idmap.c
> +++ b/fs/nfs/idmap.c
> @@ -185,7 +185,7 @@ static ssize_t nfs_idmap_request_key(const char *name, size_t nam
>         }
>  
>         rcu_read_lock();
> -       rkey->perm |= KEY_USR_VIEW;
> +       rkey->perm |= KEY_USR_VIEW|KEY_USR_WRITE;
>  
>         ret = key_validate(rkey);
>         if (ret < 0)
> 

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@...app.com
www.netapp.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/