linux-kernel - Re: user namespace: make signal.c respect user namespaces (v5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m14ny12rra.fsf@fess.ebiederm.org>
Date:	Fri, 18 Nov 2011 10:46:17 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	"Serge E. Hallyn" <serge.hallyn@...onical.com>
Cc:	"Serge E. Hallyn" <serge@...lyn.com>, richard@....at,
	containers@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, eparis@...hat.com, oleg@...hat.com,
	dhowells@...hat.com, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: user namespace: make signal.c respect user namespaces (v5)

"Serge E. Hallyn" <serge.hallyn@...onical.com> writes:

> Quoting Eric W. Biederman (ebiederm@...ssion.com):
>> There is a small bug here.  You want to fixup q->info, not info.
>> Otherwise you might try dereferencing one of the special signals and get
>> a NULL pointer dereference.
>
> Thanks, Eric.  Oddly I've not seen this happen in quite a bit of
> testing with the kernel, but you certainly must be right.  I sent
> out a new patch to fix that.

You clearly have a different test case than I do.

I managed to trigger the oops  within about 5 minutes of just fooling
around.

You want to say &q->info not q->info in your updated patch.

Thanks,
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/