linux-kernel - Re: [PATCH] Don't spam kernel log with EKEYEXPIRED and EACCESS errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EC6AF4B.5050604@calvaedi.com>
Date:	Fri, 18 Nov 2011 20:17:31 +0100
From:	John Hughes <john@...vaedi.com>
To:	Trond Myklebust <Trond.Myklebust@...app.com>
CC:	John Hughes <john@...va.com>, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Don't spam kernel log with EKEYEXPIRED and EACCESS errors

On 11/18/2011 07:30 PM, Trond Myklebust wrote:
> On Fri, 2011-11-18 at 17:20 +0100, John Hughes wrote:
>    
>> Don't write anything to the log if a user Kerberos ticket expires or is missing,
>> these are not kernel problems.
>>
>> Signed-off-by: John Hughes<john@...va.com>
>>
>> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
>> index 39914be..18897cb 100644
>> --- a/fs/nfs/nfs4state.c
>> +++ b/fs/nfs/nfs4state.c
>> @@ -1339,14 +1339,6 @@ static void nfs4_state_start_reclaim_nograce(struct nfs_client *clp)
>>    	nfs4_state_mark_reclaim_helper(clp, nfs4_state_mark_reclaim_nograce);
>>    }
>>
>> -static void nfs4_warn_keyexpired(const char *s)
>> -{
>> -	printk_ratelimited(KERN_WARNING "Error: state manager"
>> -			" encountered RPCSEC_GSS session"
>> -			" expired against NFSv4 server %s.\n",
>> -			s);
>> -}
>>      
> NACK. This is useful.
>
>    
>> -
>>    static int nfs4_recovery_handle_error(struct nfs_client *clp, int error)
>>    {
>>    	switch (error) {
>> @@ -1378,7 +1370,6 @@ static int nfs4_recovery_handle_error(struct nfs_client *clp, int error)
>>    			return 0;
>>    		case -EKEYEXPIRED:
>>    			/* Nothing we can do */
>> -			nfs4_warn_keyexpired(clp->cl_hostname);
>>    			return 0;
>>    	}
>>    	return error;
>>      


>> @@ -1620,7 +1611,6 @@ static void nfs4_set_lease_expired(struct nfs_client *clp, int status)
>>    		break;
>>
>>    	case -EKEYEXPIRED:
>> -		nfs4_warn_keyexpired(clp->cl_hostname);
>>      
> NACK. This means that the server can't even recover it's lease. It
> shouldn't even trigger if you install a machine credential.
>    

Ok, couldn't see why there were two such warnings.  Maybe the error 
should be more alarming in this case?

>    
>> 	case -NFS4ERR_NOT_SAME: /* FixMe: implement recovery
>>    				 * in nfs4_exchange_id */
>>    	default:
>> @@ -1728,8 +1718,9 @@ static void nfs4_state_manager(struct nfs_client *clp)
>>    	} while (atomic_read(&clp->cl_count)>   1);
>>    	return;
>>    out_error:
>> -	printk(KERN_WARNING "Error: state manager failed on NFSv4 server %s"
>> -			" with error %d\n", clp->cl_hostname, -status);
>> +	if (status != -EACCESS)
>> +		printk(KERN_WARNING "Error: state manager failed on NFSv4 server %s"
>> +				" with error %d\n", clp->cl_hostname, -status);
>>      
> Obviously not even compile tested...
>    

Oh dear, my sins have found me out.  Sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/