| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Nov 2011 12:11:02 +0100 From: Ondrej Zary <linux@...nbow-software.org> To: "Tabi Timur-B04825" <B04825@...escale.com> Cc: "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>, Florian Tobias Schandinat <FlorianSchandinat@....de>, Paul Mundt <lethal@...ux-sh.org>, Kernel development list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v3.1] [resend] Resurrect Intel740 driver: i740fb On Saturday 19 November 2011 00:53:27 Tabi Timur-B04825 wrote: > On Fri, Nov 18, 2011 at 2:54 PM, Ondrej Zary <linux@...nbow-software.org> wrote: > > Hello, > > this is an v3 attempt to resurrect an old (like 2.4.19) out-of-tree > > driver for Intel740 graphics cards and modify it for recent kernels. The > > old driver is located at: > > http://sourceforge.net/projects/i740fbdev/files/ > > Would you please run checkpatch.pl on the patch and fix the complaints > it has? I get this: > > total: 45 errors, 67 warnings, 1619 lines checked > > This patch has tons of style problems. The 45 errors are in i740_calc_fifo(), which now looks good and is readable. Reformatting according to checkpatch makes it look bad and unredable. This was already discussed before. The warnings are lines over 80 characters, which are common in most fb drivers. Splitting them makes code hard to read. -- Ondrej Zary -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists