linux-kernel - Re: [PATCH 1/1] __send_signal: pass q->info, not info, to userns_fixup_signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EC7D419.1090404@gmail.com>
Date:	Sat, 19 Nov 2011 17:06:49 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Serge Hallyn <serge.hallyn@...onical.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>, richard@....at,
	containers@...ts.linux-foundation.org, oleg@...hat.com,
	eparis@...hat.com, linux-kernel@...r.kernel.org,
	dhowells@...hat.com
Subject: Re: [PATCH 1/1] __send_signal: pass q->info, not info, to userns_fixup_signal_uid
 (v2)

On 11/19/2011 01:41 AM, Serge Hallyn wrote:
> Eric Biederman pointed out that passing info is a bug and could lead
> to a NULL pointer deref to boot.

It would be great if you could describe what bug you are fixing in fact
in the commit log. "Something that could lead to a bug" is not helpful
at all.

A link to the thread where Eric pointed *that* out would be enough.

> A collection of signal, securebits, filecaps, cap_bounds, and a few other ltp
> tests passed with this kernel.
> 
> Changelog:
>     Nov 18: previous patch missed a leading '&'
> 
> Signed-off-by: Serge Hallyn <serge.hallyn@...onical.com>
> ---
>  kernel/signal.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/signal.c b/kernel/signal.c
> index c0f0782..170586b 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -1118,7 +1118,7 @@ static int __send_signal(int sig, struct siginfo *info, struct task_struct *t,
>  			break;
>  		}
>  
> -		userns_fixup_signal_uid(info, t);
> +		userns_fixup_signal_uid(&q->info, t);
>  
>  	} else if (!is_si_special(info)) {
>  		if (sig >= SIGRTMIN && info->si_code != SI_USER) {

thanks,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/