linux-kernel - Re: [PATCH v2.2 1/7] crypto: GnuPG based MPI lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111119143337.cd84cfc59a78e0378dbd4089@canb.auug.org.au>
Date:	Sat, 19 Nov 2011 14:33:37 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Dmitry Kasatkin <dmitry.kasatkin@...el.com>
Cc:	linux-security-module@...r.kernel.org,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	zohar@...ux.vnet.ibm.com, dhowells@...hat.com,
	herbert@...dor.apana.org.au, James Morris <jmorris@...ei.org>
Subject: Re: [PATCH v2.2 1/7] crypto: GnuPG based MPI lib - source files
 (part 1)

Hi all,

On Wed, 19 Oct 2011 14:51:30 +0300 Dmitry Kasatkin <dmitry.kasatkin@...el.com> wrote:
>
> Adds the multi-precision-integer maths library which was originally taken
> from GnuPG and ported to the kernel by (among others) David Howells.
> This version is taken from Fedora kernel 2.6.32-71.14.1.el6.
> The difference is that checkpatch reported errors and warnings have been fixed.
> 
> This library is used to implemenet RSA digital signature verification
> used in IMA/EVM integrity protection subsystem.
> 
> Due to patch size limitation, the patch is divided into 4 parts.

I just noticed that this has been added to the "next" branch of the
security tree (and thus into the next release of linux-next).  I think
that these patches should be rearranged as in their current form, they
break bisection (since the files in this patch reference include files in
a latter patch).   We generally prefer large patches to be broken up into
logical sub patches rather than just along file boundaries.

In this case, even though it was broken up for review, it could have been
committed as one large commit (assuming that there is no sensible way to
break it up).
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped