linux-kernel - Re: [PATCH v2] ext4: group info caches set to SLAB_MEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd_YXUymFjbxgXwV+pXJNvPhq-W_Pi96mU3NodO3yyNTrg@mail.gmail.com>
Date:	Sun, 20 Nov 2011 14:45:32 +0900
From:	NamJae Jeon <linkinjeon@...il.com>
To:	tytso@....edu
Cc:	linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org,
	Namjae Jeon <linkinjeon@...il.com>,
	Amit Sahrawat <amit.sahrawat83@...il.com>
Subject: Re: [PATCH v2] ext4: group info caches set to SLAB_MEM_SPREAD flags.

2011/11/20 Namjae Jeon <linkinjeon@...il.com>:
> I try to set to SLAB_MEM_SPREAD flags in groups info caches accoding to http://lwn.net/Articles/173654/.
> And other filesystems have already set to this flags when using slab caches in fs.
> I believe that it is useful by original Paul jackson's patch and other fs is currently using this flags.
> Ted's opinion is that theoretically it would be sound to have that flag set with groups info slab cache.
>
> Signed-off-by: Namjae Jeon <linkinjeon@...il.com>
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@...il.com>
> ---
>  fs/ext4/mballoc.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index e2d8be8..7aacbbe 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2407,7 +2407,8 @@ static int ext4_groupinfo_create_slab(size_t size)
>                                bb_counters[blocksize_bits + 2]);
>
>        cachep = kmem_cache_create(ext4_groupinfo_slab_names[cache_index],
> -                                       slab_size, 0, SLAB_RECLAIM_ACCOUNT,
> +                                       slab_size, 0, SLAB_RECLAIM_ACCOUNT |
> +                                       SLAB_MEM_SPREAD,
>                                        NULL);
>
>        ext4_groupinfo_caches[cache_index] = cachep;
> --
> 1.7.4.4
>
>
Hi. Ted.
This patch is not really meaningful ? or you need to see performance
data although cpuset mem spread flags patch is proved before.
I am waiting for your decision.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/