linux-kernel - Re: [PATCH v2 5/6] KVM: sort memslots by its size and use line search

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EC8E43E.1040902@redhat.com>
Date:	Sun, 20 Nov 2011 13:27:58 +0200
From:	Avi Kivity <avi@...hat.com>
To:	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
CC:	Marcelo Tosatti <mtosatti@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v2 5/6] KVM: sort memslots by its size and use line search

On 11/20/2011 01:26 PM, Avi Kivity wrote:
> >
> >  int kvm_vcpu_init(struct kvm_vcpu *vcpu, struct kvm *kvm, unsigned id);
> >  void kvm_vcpu_uninit(struct kvm_vcpu *vcpu);
> > @@ -335,7 +340,14 @@ static inline struct kvm_memslots *kvm_memslots(struct kvm *kvm)
> >  static inline struct kvm_memory_slot *
> >  id_to_memslot(struct kvm_memslots *slots, int id)
> >  {
> > -	return &slots->memslots[id];
> > +	int i;
> > +
> > +	for (i = 0; i < KVM_MEM_SLOTS_NUM; i++)
> > +		if (slots->memslots[i].id == id)
> > +			return &slots->memslots[i];
> > +
>
> Is that in any hot path?  we could make an array for doing this translation.

Never mind, I see patch 6.  I should have known you wouldn't leave it
like that.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/