| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAC7Lmnv=bHN+QVDh7PWWEY0s41fNTgxo4eQFBORs3ky48Av6XA@mail.gmail.com> Date: Sun, 20 Nov 2011 19:19:55 -0200 From: Eugeni Dodonov <eugeni@...onov.net> To: Keith Packard <keithp@...thp.com> Cc: intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org Subject: Re: [PATCH] drm/i915: By default, enable RC6 on IVB and SNB when reasonable On Sat, Nov 19, 2011 at 16:32, Keith Packard <keithp@...thp.com> wrote: > On Sat, 19 Nov 2011 07:25:09 -0200, Eugeni Dodonov <eugeni@...onov.net> wrote: > >> Just one question I caught on 2nd read. Shouldn't we have #else within >> this #ifdef block, to return 1? Otherwise, if CONFIG_INTEL_IOMMU is >> not defined, we'll always disable rc6. > > Oops! Thanks for catching this. Here's a new version of that function > (the rest of the patch is the same). This one has explicit conditions > for Ironlake and Sandybridge (when CONFIG_INTEL_IOMMU is set), allowing > the Ivybridge and Sandybridge-without-IOMMU cases to take the default > path. This will also cause all future chips to enable rc6 by default. Great, I think it catches all cases now. Reviewed-by: Eugeni Dodonov <eugeni.dodonov@...el.com> Thanks! -- Eugeni Dodonov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists