linux-kernel - Re: [PATCH] x86, mrst: Casting (void *) value returned by kmalloc is useless

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1111201427270.30815@chino.kir.corp.google.com>
Date:	Sun, 20 Nov 2011 14:28:36 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Pekka Enberg <penberg@...nel.org>
cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Thomas Meyer <thomas@...3r.de>, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, mrst: Casting (void *) value returned by kmalloc
 is useless

On Fri, 18 Nov 2011, Pekka Enberg wrote:

> >> diff -u -p a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
> >> --- a/arch/x86/platform/mrst/mrst.c 2011-11-07 19:37:40.283168752 +0100
> >> +++ b/arch/x86/platform/mrst/mrst.c 2011-11-08 09:19:24.686513740 +0100
> >> @@ -331,7 +331,7 @@ static int __init sfi_parse_gpio(struct
> >>       num = SFI_GET_NUM_ENTRIES(sb, struct sfi_gpio_table_entry);
> >>       pentry = (struct sfi_gpio_table_entry *)sb->pentry;
> >>
> >> -     gpio_table = (struct sfi_gpio_table_entry *)
> >> +     gpio_table =
> >>                               kmalloc(num * sizeof(*pentry), GFP_KERNEL);
> 
> On Fri, Nov 18, 2011 at 12:16 PM, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> > True but the formatting also wants fixing with that change.
> 
> A conversion to kcalloc() would make sense as well.

Seems unnecessary to zero the array if it's going to immediately copy the 
gpio table, though.