lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20111121093801.GA1062@udknight.homenetwork>
Date:	Mon, 21 Nov 2011 17:38:01 +0800
From:	wangyanqing <udknight@...il.com>
To:	warns@...-sense.de
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	tj@...nel.org, warns@...-sense.de, jaxboe@...ionio.com
Subject: [PATCH] fs:partitions:efi.c: bugfix a issue in find_valid_gpt

I meet a 3T disk, which partitioned by Windows 7,
and linux report unknow partition table. But it can been
detected the partition table when I add gpt to boot
parameter.

This issue caused by the find_valid_gpt function will fail
out when check the legacy mbr failed if there is no gpt boot
parameter.

if boot without gpt, we should fail back to check the guid
partition table when check the legacy mbr failed instead of
fail out.

Signed-off-by: Wang YanQing <udknight@...il.com>
---
 fs/partitions/efi.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/partitions/efi.c b/fs/partitions/efi.c
index 6296b40..302631e 100644
--- a/fs/partitions/efi.c
+++ b/fs/partitions/efi.c
@@ -543,8 +543,6 @@ static int find_valid_gpt(struct parsed_partitions *state, gpt_header **gpt,
                         good_pmbr = is_pmbr_valid(legacymbr);
                         kfree(legacymbr);
                 }
-                if (!good_pmbr)
-                        goto fail;
         }
 
 	good_pgpt = is_gpt_valid(state, GPT_PRIMARY_PARTITION_TABLE_LBA,
-- 
1.7.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ