linux-kernel - RE: [PATCH] driver/rtc/rtc-s3c: Fix driver clock enable/disable balance issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <03e901cca83b$69a48bf0$3ceda3d0$%kim@samsung.com>
Date:	Mon, 21 Nov 2011 19:50:41 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	jhbird.choi@...sung.com, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org
Cc:	'Alessandro Zummo' <a.zummo@...ertech.it>,
	akpm@...ux-foundation.org
Subject: RE: [PATCH] driver/rtc/rtc-s3c: Fix driver clock enable/disable
 balance issues

jhbird.choi@...sung.com wrote:
> 
> From: Jonghwan Choi <jhbird.choi@...sung.com>
> 
> If an error occurs after clock is enabled, it can become unbalanced.
> 
> Signed-off-by: Jonghwan Choi <jhbird.choi@...sung.com>

Cc: stable@...nel.org
Acked-by: Kukjin Kim <kgene.kim@...sung.com>

(Cc'ed Andrew Morton)

Hi Andrew,

If you're ok with this, could you please pick this up in your tree?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> ---
>  drivers/rtc/rtc-s3c.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
> index 7639ab9..5b979d9 100644
> --- a/drivers/rtc/rtc-s3c.c
> +++ b/drivers/rtc/rtc-s3c.c
> @@ -202,7 +202,6 @@ static int s3c_rtc_settime(struct device *dev, struct
rtc_time
> *tm)
>  	void __iomem *base = s3c_rtc_base;
>  	int year = tm->tm_year - 100;
> 
> -	clk_enable(rtc_clk);
>  	pr_debug("set time %04d.%02d.%02d %02d:%02d:%02d\n",
>  		 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday,
>  		 tm->tm_hour, tm->tm_min, tm->tm_sec);
> @@ -214,6 +213,7 @@ static int s3c_rtc_settime(struct device *dev, struct
rtc_time
> *tm)
>  		return -EINVAL;
>  	}
> 
> +	clk_enable(rtc_clk);
>  	writeb(bin2bcd(tm->tm_sec),  base + S3C2410_RTCSEC);
>  	writeb(bin2bcd(tm->tm_min),  base + S3C2410_RTCMIN);
>  	writeb(bin2bcd(tm->tm_hour), base + S3C2410_RTCHOUR);
> --
> 1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/