linux-kernel - Re: [PATCH v2] pinctrl: indicate GPIO direction on single GPIO request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZ0rgNzd1SKfE47J0yR51g0hd+mwuA7Ku6UD_wa3Mzi1g@mail.gmail.com>
Date:	Mon, 21 Nov 2011 13:12:54 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Igor Grinberg <grinberg@...pulab.co.il>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, Stephen Warren <swarren@...dia.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Barry Song <21cnbao@...il.com>,
	Shawn Guo <shawn.guo@...escale.com>,
	Thomas Abraham <thomas.abraham@...aro.org>,
	Dong Aisheng <dong.aisheng@...aro.org>,
	Rajendra Nayak <rajendra.nayak@...aro.org>
Subject: Re: [PATCH v2] pinctrl: indicate GPIO direction on single GPIO request

On Thu, Nov 17, 2011 at 4:29 PM, Igor Grinberg <grinberg@...pulab.co.il> wrote:

> You haven't responded to my request for the previous version...

Sorry, probably missed it :-(

>>  static int pin_request(struct pinctrl_dev *pctldev,
>>                      int pin, const char *function,
>> -                    struct pinctrl_gpio_range *gpio_range)
>> +                    struct pinctrl_gpio_range *gpio_range,
>> +                    bool gpio_direction)
>
> can this (and other instances) be:
> s/gpio_direction/gpio_direction_out/

Yes I realized this morning that this is a better solution.
Will post some v3 ASAP.

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/