linux-kernel - Re: [PATCH 2/2] ARM: amba: Auto-generate AMBA driver module aliases during modpost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111121141817.GB14679@localhost.localdomain>
Date:	Mon, 21 Nov 2011 14:18:17 +0000
From:	Dave Martin <dave.martin@...aro.org>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	patches@...aro.org
Subject: Re: [PATCH 2/2] ARM: amba: Auto-generate AMBA driver module aliases
 during modpost

On Mon, Nov 21, 2011 at 02:10:22PM +0100, Uwe Kleine-König wrote:
> Hello Dave,
> 
> On Mon, Nov 21, 2011 at 10:48:30AM +0000, Dave Martin wrote:
> > --- a/drivers/amba/bus.c
> > +++ b/drivers/amba/bus.c
> > @@ -52,7 +52,14 @@ static int amba_uevent(struct device *dev, struct kobj_uevent_env *env)
> >  	int retval = 0;
> >  
> >  	retval = add_uevent_var(env, "AMBA_ID=%08x", pcdev->periphid);
> > -	return retval;
> > +	if (retval)
> > +		return retval;
> > +
> > +	retval = add_uevent_var(env, "MODALIAS=amba:d%08X", pcdev->periphid);
> > +	if (retval)
> > +		return retval;
> > +
> > +	return 0;
> Just return retval here?

Hmmm, yes -- I'm not sure why I did things that way.
I'll get rid of the final if () and do as you suggest.

Cheers
---Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/