linux-kernel - Re: [PATCH] drm, i915: Fix memory leak in i915_gem_busy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111121162306.GB3807@phenom.ffwll.local>
Date:	Mon, 21 Nov 2011 17:23:06 +0100
From:	Daniel Vetter <daniel@...ll.ch>
To:	Rakib Mullick <rakib.mullick@...il.com>
Cc:	dri-devel <dri-devel@...ts.freedesktop.org>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Keith Packard <keithp@...thp.com>
Subject: Re: [PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl().

On Wed, Nov 16, 2011 at 12:49:28AM +0600, Rakib Mullick wrote:
> 
> A call to i915_add_request() has been made in function i915_gem_busy_ioctl(). i915_add_request can fail,
> so in it's exit path previously allocated memory needs to be freed.
> 
> Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>

Indeed, nice catch (albeit totally unlikely to be hit, because the error
only happens when the gpu ceases to progress in the ring, so imo not
stable material). Keith, please pick this up for fixes, thanks.

Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>
-- 
Daniel Vetter
Mail: daniel@...ll.ch
Mobile: +41 (0)79 365 57 48
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/