linux-kernel - Re: [PATCH] sdhci-pci register legacy PCI PM or runtime PM not both

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111122004747.GN24999@spacedout.fries.net>
Date:	Mon, 21 Nov 2011 18:47:47 -0600
From:	David Fries <david@...es.net>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
	Chris Ball <cjb@...top.org>,
	Yunpeng Gao <yunpeng.gao@...el.com>
Subject: Re: [PATCH] sdhci-pci register legacy PCI PM or runtime PM not both

On Mon, Nov 21, 2011 at 10:48:20AM +0200, Adrian Hunter wrote:
> On 20/11/11 23:29, David Fries wrote:
> > From: David Fries <David@...es.net>
> > 
> > pci_has_legacy_pm_support says to not register both legacy PM
> > and runtime PM callbacks, modified ifdefs.
> 
> Hasn't this already been done in Chris mmc tree i.e.
> 
> commit f353f593fe449178a8cb01cefe559dba125ab8b1
> Author: Manuel Lauss <manuel.lauss@...glemail.com>
> Date:   Thu Nov 3 11:09:45 2011 +0100
> 
>     mmc: sdhci: remove "state" argument from sdhci_suspend_host

Good call.  It looks like a better solution than what I posted.  I
tried it and it also worked.  I would classify this as a regression in
mainline (suspend didn't used to generate warnings) until a fix is
merged.  I'm good for now, but I doubt I'll be the only one running
into it.

-- 
David Fries <david@...es.net>    PGP pub CB1EE8F0
http://fries.net/~david/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/