linux-kernel - Re: [PATCH] MIPS: Add RTC support for loongson1B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkda_M0voVTFAHUU8XaMrpgTfac2fiQY7-RhkwZ_BHYT+0w@mail.gmail.com>
Date:	Tue, 22 Nov 2011 10:47:45 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	zhzhl555@...il.com
Cc:	a.zummo@...ertech.it, rtc-linux@...glegroups.com,
	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
	ralf@...ux-mips.org, keguang.zhang@...il.com, wuzhangjin@...il.com,
	r0bertz@...too.org
Subject: Re: [PATCH] MIPS: Add RTC support for loongson1B

On Mon, Nov 21, 2011 at 9:37 AM,  <zhzhl555@...il.com> wrote:

> From: zhao zhang <zhzhl555@...il.com>
>
> This patch add RTC support(TOY counter0) for loongson1B
> Signed-off-by: zhao zhang <zhzhl555@...il.com>
(...)
> +       __raw_writel(v, SYS_TOYWRITE0);

Why are you using __raw_* accessors everywhere?
Is something wrong with just writel()/readl() on loongson?

When I look in arch/mips/include/asm/io.h they actually
seem to be #defined to their __raw_* counterparts anyway
so it cannot hurt.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/