linux-kernel - RE: [PATCH v2 5/5] perf: Enable applicable siblings when group leader is enable-on-exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1321971798.14799.12.camel@twins>
Date:	Tue, 22 Nov 2011 15:23:18 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	"Zhu, DengCheng" <dczhu@...s.com>
Cc:	"Barzilay, Eyal" <eyal@...s.com>,
	"Fortuna, Zenon" <zenon@...s.com>,
	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	"ralf@...ux-mips.org" <ralf@...ux-mips.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 5/5] perf: Enable applicable siblings when group
 leader is enable-on-exec

On Tue, 2011-11-22 at 14:20 +0000, Zhu, DengCheng wrote:
> > @@ -2463,11 +2461,25 @@ static int event_enable_on_exec(struct p
> >        if (event->state >= PERF_EVENT_STATE_INACTIVE)
> >                return 0;
> >
> > -       __perf_event_mark_enabled(event, ctx);
> > +       event->state = PERF_EVENT_STATE_INACTIVE;
> >
> >        return 1;
> >  }
> 
> By simply setting the event state in here, we bypass time stamp stuff as a result.
> This might lead to inaccuracies... 

Ah, but it calls a __perf_event_mark_enabled() at the tail of
group_enable_on_exec() which should fix that up, right?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/