linux-kernel - Re: [PATCH] percpu: fix chunk range calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111122160208.GA3250@google.com>
Date:	Tue, 22 Nov 2011 08:02:08 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Dave Young <dyoung@...hat.com>
Cc:	WANG Cong <xiyou.wangcong@...il.com>, kexec@...ts.infradead.org,
	tim@...ecast.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] percpu: fix chunk range calculation

Hello, Dave.

On Tue, Nov 22, 2011 at 11:00:28AM +0800, Dave Young wrote:
> > Maybe we can add comment there how it can be further simplified and
> > why things look more complicated than necessary?
> 
> I wonder if it's good to add something like CONFIG_PER_CPU_DEBUG?

Yeah, having more comprehensive sanity checks w/ CONFIG_PER_CPU_DEBUG
would be really nice.

> Anyway I have no strong opinion with this. I'm fine to either of adding
> comment and put it into debug around.

I mostly just don't want to lose the minimal but useful checks in the
phys conversion function.  Please feel free to improve it.

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/