linux-kernel - Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9315670.oOZAWsuHPb@wuerfel>
Date:	Tue, 22 Nov 2011 21:02:08 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linaro-dev@...ts.linaro.org
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Mike Turquette <mturquette@...aro.org>,
	linus.walleij@...ricsson.com, sboyd@...cinc.com,
	broonie@...nsource.wolfsonmicro.com, magnus.damm@...il.com,
	linux-kernel@...r.kernel.org, eric.miao@...aro.org, aul@...an.com,
	tglx@...utronix.de, linux-arm-kernel@...ts.infradead.org,
	patches@...aro.org, skannan@...cinc.com, linux@....linux.org.uk,
	arnd.bergmann@...aro.org, linux-omap@...r.kernel.org,
	jeremy.kerr@...onical.com
Subject: Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

On Tuesday 22 November 2011 12:19:51 Grant Likely wrote:
> On Tue, Nov 22, 2011 at 11:01 AM, Mike Turquette <mturquette@...aro.org> wrote:
>
> > Others have requested to have knobs made available for actually
> > performing clk_enable/clk_disable and even clk_set_rate from
> > userspace.  I hate this idea and won't implement it.  I encourage
> > anyone that needs this to do it in debugfs.
> >
> > Does that work-split make sense to you, or do you still not like the
> > idea of having topology and read-only info in sysfs?
> 
> Unless there is a solid real-world use case for exporting this data to
> userspace, I do not think sysfs is a good idea.  As long as the usage
> (beyond debug) is theoretical I think the whole thing should be in
> debugfs.  It can always be moved at a later date If a real use case
> does become important.

I would recomment not to spend any time on implementing a debugfs interface
for this right now. As far as I can tell, nothing relies on exporting
the structure to user space, so Mike's time is better spent on getting the
other four patches merged.

Note that the static topology information about clocks will already be
visible in /proc/devicetree when that is enabled and the clocks are
described in the .dts file.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/