linux-kernel - Re: [git pull] vfs fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111122210930.GJ2203@ZenIV.linux.org.uk>
Date:	Tue, 22 Nov 2011 21:09:30 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [git pull] vfs fix

On Tue, Nov 22, 2011 at 09:48:36AM -0800, Linus Torvalds wrote:
> On Tue, Nov 22, 2011 at 9:44 AM, Al Viro <viro@...iv.linux.org.uk> wrote:
> > Really embarrassing braino; kudos to jlayton for catching that one.
> > Please, pull from
> > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus
> >
> > Al Viro (1):
> > ? ? ?mount_subtree() pointless use-after-free
> 
> Hmm. That's not at all what I get.
> 
> Or rather, that's just *one* of the commits I get. I also get these two:
> 
>       microblaze: bury asm/namei.h
>       iio: fix a leak due to improper use of anon_inode_getfd()
> 
> which look like they may be valid, but for all I know you meant to
> leave them for the next merge window. So not pulled. Please check your
> tree,

Umm...  OK, I see what happened - buggered script generating
shortlog/diffstat plus me not noticing that it hadn't reported a couple
of fixes I'd put there yesterday.  All 3 are intended to be sent;
iio is an outright bugfix, microblaze one could wait, in theory, but
it's guaranteed to be safe (removal of header nothing includes, done on
all architectures years ago, with microblaze tree apparently copying it
from sparc and keeping all along) and the sooner such things are buried,
the fewer places will copy that *again*...

Anyway, consider that a pull request for all 3 commits.  Proper shortlog
and diffstat follow.

Shortlog:
Al Viro (3):
      microblaze: bury asm/namei.h
      iio: fix a leak due to improper use of anon_inode_getfd()
      mount_subtree() pointless use-after-free

Diffstat:
 arch/microblaze/include/asm/namei.h     |   22 ----------------------
 drivers/staging/iio/industrialio-core.c |   10 +++++++++-
 fs/namespace.c                          |    6 ++++--
 3 files changed, 13 insertions(+), 25 deletions(-)


FWIW, the fixed form of script follows; if you see any potential problems in
it, please tell:
echo Shortlog:
base=`git merge-base origin "$1"`
git log --pretty=short "$base..$1" | git shortlog
echo Diffstat:
git diff --stat -M "$base..$1"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/