linux-kernel - [PATCH] x86: mpparse: account for bus types other than ISA and PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111122215000.GA9151@elie.hsd1.il.comcast.net>
Date:	Tue, 22 Nov 2011 15:50:01 -0600
From:	Jonathan Nieder <jrnieder@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	Dan McGrath <troubledaemon@...il.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Ingo Molnar <mingo@...e.hu>,
	Alexey Starikovskiy <aystarik@...il.com>
Subject: [PATCH] x86: mpparse: account for bus types other than ISA and PCI

From: Bjorn Helgaas <bhelgaas@...gle.com>
Date: Sun, 25 Sep 2011 15:29:00 -0600

In commit f8924e770e04 ("x86: unify mp_bus_info"), the 32-bit and
64-bit versions of MP_bus_info were rearranged to match each other
better.  Unfortunately it introduced a regression: prior to that
change we used to always set the mp_bus_not_pci bit, then clear it if
we found a PCI bus.  After it, we set mp_bus_not_pci for ISA buses,
clear it for PCI buses, and leave it alone otherwise.

In the cases of ISA and PCI, there's not much difference.  But ISA is
not the only non-PCI bus, so it's better to always set mp_bus_not_pci
and clear it only for PCI.

Without this change, Dan's Dell PowerEdge 4200 panics on boot with a
log indicating interrupt routing trouble unless the "noapic" option is
supplied.  With this change, the machine boots reliably without
"noapic".

Fixes http://bugs.debian.org/586494

Reported-bisected-and-tested-by: Dan McGrath <troubledaemon@...il.com>
Cc: stable@...r.kernel.org	# 2.6.26+
Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
[jrnieder@...il.com: clarified commit message]
Signed-off-by: Jonathan Nieder <jrnieder@...il.com>
---
Hi,

Fix for an old regression.  Not present in linux-next, so seems to
have been forgotten.  The patch visited LKML a few times --- I suppose
it was not a great time for getting patches in. :)

References:

 - 2011-09-25: debugging session [1]
 - 2011-09-25: first official appearance [2]
   2011-10-17: ping.  Ingo writes:
    "Please resend - this is one of the mails that got lost in my korg
    email disconnect.

    Patch looks good at first sight."
 - 2011-10-18: resent [3]
   2011-10-31: ping
 - 2011-11-08: resent [4]
   2011-11-14: plaintive ping
 - 2011-11-21: resent [5]

[1] http://thread.gmane.org/gmane.linux.kernel/1194982/focus=1195043
[2] http://thread.gmane.org/gmane.linux.kernel/1195093
[3] http://thread.gmane.org/gmane.linux.kernel/1204831
[4] http://thread.gmane.org/gmane.linux.kernel/1212763
[5] http://thread.gmane.org/gmane.linux.kernel/1218323

 arch/x86/kernel/mpparse.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index 9103b89c145a..0741b062a304 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -95,8 +95,8 @@ static void __init MP_bus_info(struct mpc_bus *m)
 	}
 #endif
 
+	set_bit(m->busid, mp_bus_not_pci);
 	if (strncmp(str, BUSTYPE_ISA, sizeof(BUSTYPE_ISA) - 1) == 0) {
-		set_bit(m->busid, mp_bus_not_pci);
 #if defined(CONFIG_EISA) || defined(CONFIG_MCA)
 		mp_bus_id_to_type[m->busid] = MP_BUS_ISA;
 #endif
-- 
1.7.8.rc3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/