linux-kernel - Re: [PATCH] bcd: limit bin2bcd input value to lie between 0-99

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111122143214.5cc8f17e.akpm@linux-foundation.org>
Date:	Tue, 22 Nov 2011 14:32:14 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	vbyravarasu@...dia.com
Cc:	torvalds@...ux-foundation.org, a.zummo@...ertech.it,
	bunk@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcd: limit bin2bcd input value to lie between 0-99

On Wed, 16 Nov 2011 10:41:32 +0530
vbyravarasu@...dia.com wrote:

> From: venu byravarasu <vbyravarasu@...dia.com>
> 
> Current implementation of bin2bcd allows any value
> between 0x0 to 0xF to be stored in the most significant
> nibble of its returned value, against to the BCD limits
> of 0 - 9. Hence fixing it.
> 
> e.g. say val passed to bin2bcd is 123.
> In that case the expected value to be returned by
> this function is 0x23.
> However, without the fix being added, it would
> return 0xC3.
> 

I'm not sure that I agree.  Passing 123 to bin2bcd() is a bug, isn't
it?  We want to know about bugs so we can fix them, and quietly repairing
thngs in callees prevents that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/