linux-kernel - Re: [PATCH 03/15] samsung-laptop: don't handle backlight if handled by acpi/video

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111122221633.GA24283@suse.de>
Date:	Tue, 22 Nov 2011 14:16:33 -0800
From:	Greg KH <gregkh@...e.de>
To:	Corentin Chary <corentincj@...aif.net>
Cc:	platform-driver-x86@...r.kernel.org,
	Matthew Garrett <mjg@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/15] samsung-laptop: don't handle backlight if handled
 by acpi/video

On Tue, Nov 22, 2011 at 11:02:34PM +0100, Corentin Chary wrote:
> samsung-laptop is not at all related to ACPI, but since this interface
> is not documented at all, and the driver has to use it at load to
> understand how it works on the laptop, I think it's a good idea to
> disable it if a better solution is available.

I wish this would work, but on the machine that I had, there was a valid
ACPI table for the video device, yet I was told to "ignore it, it
doesn't work and use the sabi interface instead", so this patch would
break that machine :(

We might want to trigger off of the machine type for this kind of
thing, that's the only way I can see this working properly.

So, sorry, I can't approve this patch.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/