linux-kernel - linux-next: build failure after merge of the final tree (uprobes tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111123144409.7d1816bef960a2f277aaf1b9@canb.auug.org.au>
Date:	Wed, 23 Nov 2011 14:44:09 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: linux-next: build failure after merge of the final tree (uprobes
 tree related)

Hi Srikar,

After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:

In file included from include/linux/mm_types.h:15:0,
                 from include/linux/sched.h:64,
                 from arch/powerpc/mm/mem.c:21:
include/linux/uprobes.h:174:49: error: 'struct mm_struct' declared inside parameter list [-Werror]
include/linux/uprobes.h:174:49: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]

And many more similar.

Caused by commit 61fafad13005 ("uprobes_xol" - "uprobes: slot allocation").

I have added the following patch for today:

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Wed, 23 Nov 2011 14:35:01 +1100
Subject: [PATCH] uprobes: declare mm_struct before its use in uprobes.h

Since there is a circular dependency between uprobes.h and mm_type.h

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 include/linux/uprobes.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
index 20bdd0a..091dfb8 100644
--- a/include/linux/uprobes.h
+++ b/include/linux/uprobes.h
@@ -26,6 +26,7 @@
 #include <linux/rbtree.h>
 
 struct vm_area_struct;
+struct mm_struct;
 #ifdef CONFIG_ARCH_SUPPORTS_UPROBES
 #include <asm/uprobes.h>
 #else
-- 
1.7.7.3

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped