linux-kernel - Re: [PATCH 1/1] xHCI: Adding #define values used for hub descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ54Ua4HgcDkWrcgVHNtNBmwgHh+Swn_Q2kKGLKS5+d94g07kQ@mail.gmail.com>
Date:	Wed, 23 Nov 2011 10:20:10 +0530
From:	Aman Deep <amandeep3986@...il.com>
To:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] xHCI: Adding #define values used for hub descriptor

Hi Sarah,


> >
> > Also use some #defines in places where magic numbers are being used.
>
> Looks fine to me for the xHCI changes.  I copied most of the hub
> descriptor code from EHCI, so it will need the same treatment.

Okay, thanks. I will try to make some of these changes into other host
controller drivers also as
soon as I can.

>
> Acked-by: Sarah Sharp <sarah.a.sharp@...ux.intel.com>

Thanks for the ACK, Sarah.

>
> The #defines look a bit odd to me, like you're using spaces instead of
> tabs to separate the name and value, or your mail program is converting
> tabs to spaces.  Do the numbers line up for you?

Actually, both the HUB_CHAR_TTTT and HUB_CHAR_PORTIND were already using
spaces instead of tabs. I just copied them to the lines below, thats
why they still have
spaces between define and value.

But thanks for info. I will take more care about this in future.

Do you want me to make any changes in this patch ?

>
> > Signed-off-by: Aman Deep <amandeep3986@...il.com>
> > ---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/